Fraction calculations not displaying

iceman2006 · #1 01-May-2006, 01:35

The goal of my program is to enter 2 fractions and display the results of calculations on the 2 fractions. When I run the program I am able to enter the two fractions, but am unable to view the results of the calculations. I've looked at some similar code, but they were above my skill level. I don't know what I'm doing wrong. I've added a few comments in the code. Thanks in advance for any help.

CPP / C++ / C Code:

#include <iostream>
#include <cmath>
#include <stdio.h>


using namespace std;

class fractionType
{	
public:

    void setFractionX(double Xnumerator, double Xdenominator);
    void setFractionY(double Ynumerator, double Ydenominator);
    double add();
    double subtract();
    double multiply();
    double divide();
    void print();
    double xnum, xden;
    double ynum, yden;
    double znum, zden; 
    double Xnumerator, Xdenominator;
    double Ynumerator, Ydenominator;
};

void fractionType::setFractionX(double Xnumerator, double Xdenominator)
{
	xnum = Xnumerator;
	xden = Xdenominator;
}
void fractionType::setFractionY(double Ynumerator, double Ydenominator)
{
	ynum = Ynumerator;
	yden = Ydenominator;
}
double fractionType::add()
{	
	znum = xnum * yden + ynum * xden;
	zden = xden * yden;
                return znum, zden;
	cout <<xnum <<"/"<<xden <<" + " <<ynum <<"/"<<yden <<" = " <<znum <<"/"<<zden << endl;  // just to see if anything prints... can I put this statement in here?

  }
double fractionType::subtract()
{	
	znum = xnum * yden - ynum * xden;
	zden = xden * yden;
}
double fractionType::multiply()
{	
	znum = xnum * ynum;
	zden = xden * yden;
}
double fractionType::divide()
{	
	znum = xnum * yden;
	zden = xden * ynum;
}

void fractionType::print()
{
	cout <<xnum <<"/"<<xden <<" + " <<ynum <<"/"<<yden <<" = " <<add() << endl;  // just to see if anything prints
	cout <<xnum <<"/"<<xden <<" - " <<ynum <<"/"<<yden <<" = " <<znum <<"/"<<zden << endl;  // just to see if anything prints
}


int main()
{
    fractionType Fraction;
	double Xnumerator, Xdenominator;
	double Ynumerator, Ydenominator;
	char slash;

	cout << "Enter first fraction: ";
	scanf("%d%c%d",&Xnumerator,&slash,&Xdenominator);  //is this the appropriate way to use this?
	Fraction.setFractionX(Xnumerator, Xdenominator);
	cout << "Enter second fraction: ";
	scanf("%d%c%d",&Ynumerator,&slash,&Ydenominator);
	Fraction.setFractionY(Ynumerator, Ydenominator);
	cout << endl;
    system("PAUSE");

	return 0;
}

Sokar · #2 01-May-2006, 09:48

Quote:

Originally Posted by iceman2006

I don't know what I'm doing wrong.

One thing that is not helping is doing to much at once. Just pick one thing and get it working then move to the next. What I mean is just pick multiplication of fractions get that working then move to division ...
This might be a good start.

CPP / C++ / C Code:

#include <iostream>
#include <cmath>
#include <cstdio>


using namespace std;

class fractionType
{	
public:
    void setFractionX(int Xnumerator, int Xdenominator);
    void setFractionY(int Ynumerator, int Ydenominator);
    double multiply();
    int xnum, xden;
    int ynum, yden;
    int znum, zden; 
};

void fractionType::setFractionX(int  Xnumerator, int  Xdenominator)
{
	xnum = Xnumerator;
	xden = Xdenominator;
}
void fractionType::setFractionY(int  Ynumerator, int  Ydenominator)
{
	ynum = Ynumerator;
	yden = Ydenominator;
}
double fractionType::multiply()
{	
	znum = xnum * ynum;
	zden = xden * yden;
}

int main()
{
	fractionType Fraction;
	int Xnumerator, Xdenominator;
	int Ynumerator, Ydenominator;
	char slash;

	cout << "Enter first fraction: ";
	scanf("%d%c%d",&Xnumerator,&slash,&Xdenominator);  //is this the appropriate way to use this?
	Fraction.setFractionX(Xnumerator, Xdenominator);
	cout << "Enter second fraction: ";
	scanf("%d%c%d",&Ynumerator,&slash,&Ydenominator);
	Fraction.setFractionY(Ynumerator, Ydenominator);
	cout << endl;

	cin.ignore();
	cin.get();
	//system("PAUSE");

	return 0;
}

iceman2006 · #3 01-May-2006, 14:51

You're right I was trying to do too much at once. When you simplified it for me I noticed I forgot a Fraction.print() in the Main function. Or in this case Fraction.add(), Fraction.subtract(), etc. since I will print the results after each calculation with:

Code:

cout <<xnum <<"/"<<xden <<" + " <<ynum <<"/"<<yden <<" = " <<znum <<"/"<<zden << endl;

Sokar · #4 01-May-2006, 15:13

Yes it is not as overwhelming when you break the task into little pieces.

CPP / C++ / C Code:

double fractionType::multiply()
{	
	znum = xnum * ynum;
	zden = xden * yden;
}

Did you fix this?

You might want to take a look at adding a constructor to your class. It would take the place of this.

CPP / C++ / C Code:

    void setFractionX(int Xnumerator, int Xdenominator);
    void setFractionY(int Ynumerator, int Ydenominator);

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
overloading operators in a class.	fevershark	C++ Forum	11	22-Feb-2006 20:34
fraction class program	fevershark	C++ Forum	7	31-Jan-2006 12:12
Interface for opening and displaying text file	ladyscarlet99	MS Visual C++ / MFC Forum	0	29-Sep-2005 03:34
Non-member method needs info from class... how?	Elsydeon	C++ Forum	3	19-Sep-2005 16:13
opening files and displaying text	pin215	C++ Forum	7	21-Feb-2004 22:27

Fraction calculations not displaying

Re: Fraction calculations not displaying

Re: Fraction calculations not displaying

Re: Fraction calculations not displaying