Help with reading data...getting garbage output

mnkdrt · #1 02-Dec-2005, 12:19

Hello forum, I new here and to C++ so any help would be greatly appreciated.
I am working on a program using arrays of structures and am reading data from an infile. I thought I was reading the data in correctly but am getting garbage out put when trying to just print a screen cout check.
Can any one point out what I am doing wrong.
Thanks alot.
D.

sample goods.data-
Boxing Gloves
1025 8 47 6.56 7.58 23.69
Red Trunks
2569 9 23 9.25 3.25 12.39

CPP / C++ / C Code:

struct TOOLS
{
       char Tool_Name[50];
       int Tool_N;
       int Quanity;
       int QuanityDesired;
       float Cost;
       float Price;
       float Sales;
};

int main()
{
    TOOLS L[MaxItems];
    int i = 0, count;
    ifstream fin;
    
    fin.open("goods.data");
    if(fin.fail())
    {
                  cout << "ERROR: Cannot open file to read goods.data. \n";
                  exit(1);
    }

    fin.getline(L[i].Tool_Name, 30);
    while(fin)
    {
              fin >> L[i].Tool_N >> L[i].Quanity >> L[i].QuanityDesired >> L[i].Cost >> L[i].Price >> L[i].Sales;
              fin.get();
              i++;
              fin.getline(L[i].Tool_Name, 30);
              
    }
    i = count;
    for(i = 0; i < MaxItems; i ++)
    {
          cout << L[i].Tool_Name << endl;
    }
    fin.close();
    return 0;
}

Paramesh · #2 02-Dec-2005, 13:28

Hi mnkdrt,

Welcome to GIDForums.

You are getting garbage because you should print only upto the lines read from the file.
For example, consider that the MaxItems is 5.
But your file contains only Two sets of data.

So, if you print from 0 to 4, the first two values will be correct and the third, fourth and fifth values will be garbage.

Just make a simple adjustment.
Store the number of lines read in a variable count, and use it for printing.
Like this:

CPP / C++ / C Code:

    count = i;
    for(i = 0; i < count; i ++)
    {
          cout << L[i].Tool_Name << endl;
    }

And this statement may lead to errors:

CPP / C++ / C Code:

    while(fin)

So, just put the getline statement inside the while loop. Well and Good.

Like this:

CPP / C++ / C Code:

    while(fin.getline(L[i].Tool_Name, 30))
    {
              fin >> L[i].Tool_N >> L[i].Quanity >> L[i].QuanityDesired >> L[i].Cost >> L[i].Price >> L[i].Sales;
              fin.get();
              i++;
    }

Regards,

Paramesh.

mnkdrt · #3 02-Dec-2005, 13:46

Great and thanks for the help

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[Include] Doubly-linked List	dsmith	C Programming Language	6	14-Apr-2006 13:12
Need Help reading HEX data from a sensor	Moooey	C Programming Language	4	09-Mar-2005 13:46
[CONTEST?]Data Structure Test	dsmith	C Programming Language	2	06-Jun-2004 15:13
using vector or array	oshiotse	CPP / C++ Forum	4	16-Apr-2004 10:59

Help with reading data...getting garbage output

Re: Help with reading data...getting garbage output

Re: Help with reading data...getting garbage output