convert array of decimal to array of binary

harry.net · #1 01-Nov-2005, 06:50

I have written a program to convert an array of decimal Numbers to its binary.

input is an array of size 8 , input:input[3]
cout put is an array of size 32, means each integer number in input should be represented as 4-bit in output. output: output[12]

for example this program run as below:
enter a string of NO
1
2
3
1000010011000000

this is wrong because it is showing the integer in reverse order, instead of showing 1 as 0001 it has showed 1000.

would you please check my program and tell me what's wrong with it?

CPP / C++ / C Code:

#include<iostream.h>

main()
{
	int key[3],x,j,b[13],n,m=1,d;

cout<<"enter a string of NO";

for(int i=0;i<3;i++)
		 cin>>key[i];


for ( int k=0;k<4;k++)
{
	
	x=key[k];
	 
	n=m*4;
	j=4;
	
	
	for (j=4;j>=1;j--)
	{

		d=x%2;
		b[n]=d;
		x=x/2;
		cout<<b[n];
		n--;
		
		
		
	}
	

	
	 m=m+1;
}

     return 0;

}

WaltP · #2 01-Nov-2005, 12:25

Quote:

Originally Posted by harry.net

I have written a program to convert an array of decimal Numbers to its binary.

input is an array of size 8 , input:input[3]
cout put is an array of size 32, means each integer number in input should be represented as 4-bit in output. output: output[12]

for example this program run as below:
enter a string of NO
1
2
3
1000010011000000

this is wrong because it is showing the integer in reverse order, instead of showing 1 as 0001 it has showed 1000.

would you please check my program and tell me what's wrong with it?

CPP / C++ / C Code:

#include<iostream.h>

main()
{
    int key[3], x, j, b[13], n, m=1, d;
    
    cout<<"enter a string of NO";

    for(int i = 0; i < 3; i++)
            cin >> key[i];

    for ( int k=0; k < 4; k++)
    {
        x = key[k];
        n = m * 4;
        j = 4;

        for (j = 4; j >= 1; j--)
        {
            d = x % 2;
            b[n] = d;
            x = x / 2;
            cout << b[n];
            n--;
        }

        m = m + 1;
    }
    return 0;
}

First is your formatting. I made it more consistant. Use SPACEs insead of TABs to control your format easier. And use more SPACEs in each line.

Why is your first loop inputting 0 < 3 and your second 0 < 4? This will cause a problem.

The reason you are outputting the values in reverse order is you generate each value and put it in the array in reverse order. But you output the value immediately. You want to do your ourput after you totaly load the 'b' array.

Also note you never load b[0] since n counts from 4 to 1, not 3 to 0.

Oh, and read the Guidelines please.

harry.net · #3 02-Nov-2005, 00:16

Thank you so much for your help.

I changed the things which you have mentioned, and now the program is working properly.

here is the modified program.

Code:


  CPP / C++ / C Code:
  #include<iostream.h>

int b[11];  //modified from local to global

main()
{
	int key[3], x, j, n, m=1, d;

	cout<<"enter a string of NO";

	for( int i = 0; i < 3; i++ )
		 cin>>key[i];


	for ( int k = 0; k < 3; k++ )   //modified from 4 to 3
	{
	
		x = key[k];
		n = m * 4;
		j = 3;
		n--;              // modified to start from position 3, 7, 11
	
	
		for ( j = 4; j >= 1; j-- )    
		{

			d = x % 2;
			b[n] = d;
			x = x / 2;
		    n--;
		}
	
	 m = m + 1;

}

   cout << "dec to bin ";      //modified to print the output not in reverse order
   for ( int q1 = 0; q1 <= 11 ; q1++ )
   cout << b[q1];
   cout << endl;

   return 0;

}

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
convert char array into CString?	nasaiya	MS Visual C++ / MFC Forum	11	22-Aug-2005 03:13
template comiling problems - need expert debugger!	crq	CPP / C++ Forum	1	01-Feb-2005 21:26
Hex Result giving strange answers.	Rosdahale	C Programming Language	6	07-Dec-2004 20:28
Creating N string	gwk	C Programming Language	3	20-Jul-2004 23:27

convert array of decimal to array of binary

Re: convert array of decimal to array of binary

Re: convert array of decimal to array of binary