My programs output is a string of smiley faces

scramble · #1 27-Feb-2005, 15:45

I am obviously a beginning programmer. I have a C program that takes input that is redirected from a file, strips out all vowels, and prints the rest to the screen. When I run it, it prints out a long string of smiley faces instead of the text. The redirected file is a simple text file created with notepad that contains some text.
Any suggestions?

WaltP · #2 27-Feb-2005, 16:53

Quote:

Originally Posted by scramble

I am obviously a beginning programmer. I have a C program that takes input that is redirected from a file, strips out all vowels, and prints the rest to the screen. When I run it, it prints out a long string of smiley faces instead of the text. The redirected file is a simple text file created with notepad that contains some text.
Any suggestions?

Sure.
1) Make sure you aren't outputting a string using "%c" in the printf() statement. Conversely make sure you aren't trying to output a character with "%s".
2) Be sure you aren't trying to output characters beyond the limit of your string

Also, post code sections here. Many of us won't download files -- we have enough stuff on our harddrives...

scramble · #3 27-Feb-2005, 18:10

I didn't paste the source inline in my message because the forum doesn't display some of it correctly. I just read the post on how to enclose source code. Here it is:

CPP / C++ / C Code:

#include <stdio.h>

int isvowel(char c);

int main(void)
{
	char c;
	printf("\n%s\n%s\n%s\n\n",
		"This program takes standard input redirected",
		"	from a text file, and prints it to the",
		"	screen minus all vowels.");
	while(c = getchar() != EOF){
		if(isvowel(c) == 1) {
			continue;
		}
		else putchar(c);
	}
	return 0;
}

	int isvowel(char c)
	{
		if(c=='a' || c=='e' || c=='i' || c=='o' || c=='u' || c=='y')
			return 1;
		if(c=='A' || c=='E' || c=='I' || c=='O' || c=='U' || c=='Y')
			return 1;
		else return 0;
	}

davekw7x · #4 27-Feb-2005, 19:22

Quote:

Originally Posted by scramble

Here it is:

Try printing out the characters in hex. Maybe you can figure how the values are equal to 0x01. Hint: precedence of = and !=

That is, instead of this:

CPP / C++ / C Code:

else putchar(c);

Try this:

CPP / C++ / C Code:

    else printf("%c: %02x ", c, c);

Regards,

Dave

scramble · #5 27-Feb-2005, 20:25

I changed my code as you suggested, and here is the output:

☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺:
01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 0
1 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01
☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺: 01 ☺:

I still don't understand what is going wrong. Thank you for your your help.
Scramble

scramble · #6 27-Feb-2005, 20:36

I figured it out!
I changed this:

CPP / C++ / C Code:

while(c = getchar() != EOF){

to this:

CPP / C++ / C Code:

while((c = getchar()) != EOF){

Thanks,
Scramble

machinated · #7 27-Feb-2005, 23:51

yeah the compiler is laughing at you. Don't be discouraged, it does that to all the beginners

Quote:

Originally Posted by scramble

I am obviously a beginning programmer. I have a C program that takes input that is redirected from a file, strips out all vowels, and prints the rest to the screen. When I run it, it prints out a long string of smiley faces instead of the text. The redirected file is a simple text file created with notepad that contains some text.
Any suggestions?

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Read a .html file, check that file for links	salemite	C Programming Language	10	17-Jan-2008 07:56
Re: Conversion: Binary, Decimal, Hexadecimal	WaltP	C Programming Language	1	10-May-2006 06:49
No output from loop function	crystalattice	C++ Forum	2	20-Dec-2004 20:39
using vector or array	oshiotse	C++ Forum	4	16-Apr-2004 10:59