Originally Posted by jenmaz

Hi there,

I fixed the i variable it was suppose to be n (to my knowledge). I just forgot to change it. I am still weak at looking over these minor mistakes.

I then placed your code

if ( num % n == 0)
{
IsPrim=0;
printf("%d is a divisor of %d\n", n, num);

In the script so that we could see the output.

So when I ran the program and it read these numbers from my input.txt file
6 7 28 18 496 31 24 17 36 3 19 -999

It gave me this out put which shows me that the script is reading the numbers (12 all together and stopping at -999) however it is not out puting properly because n is now = 2 not = to the input number. Then it displays n = 2 and its division and it is the same output for each 12 data imput from the text file.

Here is the output
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
2 is a divisor of -858993460
-858993460 is a divisor of 2
Press any key to continue

I understand now what is going wrong but not sure how to fix it.

Thanks in advance.
jen

Originally Posted by davekw7x

So: show us what your Prime() looks like.

General Debugging Hint: before calling a function, put in a printf() to show what the value of the arguments are:

so, in main() you would have something like:



Then, in Prime(), you would have something like


Get the idea? That makes sure that the function is working on what you think it should be working on.

Next time: don't just describe the problem, please: Show us your code.


Don't say, "I placed your code..." Say, "Here is the function, showing the code that I am using."

Regards,

Dave

Originally Posted by jenmaz

Thanks Dave,

Here is my function for Prime:

/* For prime */
int Prime(int num)
{
int n, IsPrim;

IsPrim = 1;

for(n = 2; n < num; n++);
if ( num % n == 0)
{
IsPrim=0;
printf("Divisor of prime\n");

}
if(IsPrim)
printf("It is Prim");

return n;
}

Originally Posted by davekw7x

Well, did you follow my suggestion and put the printf() in the main() program before calling Prime() and another printf() inside the Prime() function when it is entered? The idea is that you can debug your own code much faster than waiting for someone else to tell you. (I really don't mind trying to help, but I think you are better served by helping yourself.)

(Please use code tags when posting code: put [c] before the first line of code, and put [/c] after the last line.)

Look here for an explanation: http://www.gidforums.com/t-689.html

Regards,

Dave

Originally Posted by jenmaz

Thanks Dave,

I did place your code in both places and I have been testing and trying to debug my code. Again, from the test I noticed that the loop or the prime function that I have created is missing something because it does not detect the prime. I have also been surfing the net for 2 hours trying to look at prime detection formulas and can't seem to get it. I apologize if you are frustrated and thank you for your time. I will figure out some how. I am new to this so I guess I will keep tackling it.

jennifer