Added the values of an Array

bonekrusher · #1 14-Mar-2009, 08:04

Hi,

I am working on a homework assignment, which is to add the values of an array. The array is populated by user input. I am able to store the values, but unable to get the sum. My programs crashes (see comments in code). Any help or guidance is appreciated.

Code:

TITLE Arrays (lab5.asm) 
INCLUDE Irvine32.inc
.data
	startStr  	BYTE		"Hello, you will be asked to enter a number and hit enter (10 times)", 0
	enterStr  	BYTE		"Please enter a number and hit enter:", 0
	myArray  	DWORD 	10 DUP( 0)
	count 		DWORD		2	;set counter 
.code
main PROC
	mov		ecx, count		; set counter to 2
	mov		esi, OFFSET myArray	; set size of array
	mov		edx, OFFSET startStr
	call WriteString 
	call CRLF
	call getInput				; get input from users
	call arraySum				; add array sum
	call WriteInt
	call DumpRegs            
       
    exit
main ENDP

; Gets input from user
getInput PROC

	mov edx, OFFSET enterStr
	inputLoop:			; start loop
		call WriteString 
		call ReadInt		; get value from user					
		call WriteInt				
		mov  eax,	[esi]  ; store in array						
		add esi, 4		; next integer (32 bit integer use 4)
		call Crlf
		loop inputLoop	; end loop
		ret
getInput ENDP
; example from page 139
arraySum PROC
	push	esi; 		; save esi
	push	ecx		; save ecx
	mov	eax, 0	; set eax to 0
	L1:
		add eax,[esi]	; PROGRAM CRASHES HERE
		add esi, 4
		loop L1;		
		pop	esi; 	; restore esi
		pop	ecx	; restore ecx	
		ret
arraySum ENDP

END main

Howard_L · #2 17-Mar-2009, 02:01

Sorry I didn't see this. Did you get it fixed?

bonekrusher · #3 17-Mar-2009, 16:21

Hi, no I havent. I appreciate any help. This what I have so far:

Code:

TITLE Arrays (lab5.asm) 
INCLUDE Irvine32.inc
.data
	startStr  	BYTE		"Hello, you will be asked to enter a number and hit enter (10 times)", 0
	enterStr  	BYTE		"Please enter a number and hit enter:", 0
	myArray  	DWORD 	10 DUP( 0)
	count 	DWORD	2		;set counter 
.code
main PROC
	mov		ecx, count			; set counter to 2
	mov		esi, OFFSET myArray	
	mov		edx, OFFSET startStr
	call WriteString 
	call CRLF
	call getInput				; get input from users
	mov	esi, OFFSET myArray		; go to start of the array
	call arraySum				; add array sum
	call WriteInt
	call DumpRegs            
       
    exit
main ENDP

; Gets input from user
getInput PROC

	mov edx, OFFSET enterStr
	inputLoop:			; start loop
		call WriteString 
		call ReadInt			; get value from user					
		call WriteInt				
		mov  [esi], eax	 	; store in array						
		add esi, 4			; next integer (32 bit integer use 4)
		call Crlf
		loop inputLoop		; end loop
		ret
getInput ENDP
; example from page 139
arraySum PROC
	mov	esi, OFFSET myArray
	mov	eax, 0	; set eax to 0
	L1:
		
		mov eax,[esi]			
		add esi, 4			; PROGRAM CRASHES HERE
		loop L1;		
		
		ret
arraySum ENDP

END main

The program crashes at:

Code:

add esi, 4

in arraySum

Thanks for the help.

bonekrusher · #4 17-Mar-2009, 16:41

Never mind, I figured it out. I never set my loop count for my loop!
mov ecx, count

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
where is the problem and can you fix it (php)	oggie	MySQL / PHP Forum	8	14-Apr-2008 16:08
Getting a line error in register	oggie	MySQL / PHP Forum	5	13-Apr-2008 17:16
Need Help with input files.	Efferus	C++ Forum	2	24-Nov-2007 17:19
How to sort in C++ alphabetically	wilen	C++ Forum	5	20-Apr-2007 15:43
Need help deleting the last element in the array	headphone69	C++ Forum	2	15-Mar-2006 20:31

Added the values of an Array

Re: Added the values of an Array

Re: Added the values of an Array

Re: Added the values of an Array