Problem assigning strings to pointers.

lief480 · #1 07-Dec-2008, 17:12

Hi im designing a madlibs program for school and need a little bit of help.
What i want to do is beable to assign each userinput to the string pointer.

CPP / C++ / C Code:

#include<iostream>
#include<string>


using namespace std;


char *str[15] = { "Liquid", "Vehicle", "Adverb", "Exclamation", "Verb ending in -ing",
			"Part Of Body", "Vehicle", "Occupation", "Article og Clothing",
			"First Name (Male)", "First Name (Male)", "Noun", "Verb", "Sily Noise",
			"Part of the Body"};

int main()
{
	for (int i = 0; i < 15; i++)
	{
		cout << str[i] << endl;
		//getline(cin, str[i]);
		
	}
    return 0;
}

davekw7x · #2 07-Dec-2008, 18:42

Quote:

Originally Posted by lief480

Hi im designing a madlibs program for school and need a little bit of help.
What i want to do is beable to assign each user input to the string pointer.

But you don't have a string pointer. You don't have any strings. You have an array of pointers to char. Each pointer is initialized to point to a string literal somewhere in program memory. You can make it point to somewhere else, but wherever it points, there must be something for it to point to. It is illegal to try to store something in the memory that holds string literals. Although some compilers appear to let you do it, the behavior is undefined and is asking for trouble.

Why not just use an array of std::string objects?

CPP / C++ / C Code:

#include<iostream>
#include<string>

using namespace std;

string str[15] = {
    "Liquid",            "Vehicle", "Adverb",     "Exclamation",         "Verb ending in -ing",
    "Part Of Body",      "Vehicle", "Occupation", "Article og Clothing", "First Name (Male)", 
    "First Name (Male)", "Noun",    "Verb",       "Sily Noise",          "Part of the Body"
};

int main()
{

    for (int i = 0; i < 3; i++) {
        cout << "Old string: ";
        cout << str[i] << endl << endl;
        cout << "Enter a new string: ";
        getline(cin, str[i]);
        cout << "New string: " << str[i] << endl << endl;

    }

    cout << "Recap:" << endl;
    for (int i = 0; i < 15; i++) {
        cout << "  str[" << i << "] = " << str[i] << endl;
    }
    return 0;
}

Here's the output for a run. I made the first loop short so that I could test without entering all 15 things:

Code:

0   Old string: Liquid

Enter a new string: 12-year old Scotch
You entered: 12-year-old Scotch

1   Old string: Vehicle

Enter a new string: Starship
You entered: Starship

2   Old string: Adverb

Enter a new string: eerily
You entered: eerily

Recap:
  str[0] = 12-year-old Scotch
  str[1] = Starship
  str[2] = eerily
  str[3] = Exclamation
  str[4] = Verb ending in -ing
  str[5] = Part Of Body
  str[6] = Vehicle
  str[7] = Occupation
  str[8] = Article og Clothing
  str[9] = First Name (Male)
  str[10] = First Name (Male)
  str[11] = Noun
  str[12] = Verb
  str[13] = Sily Noise
  str[14] = Part of the Body

lief480 · #3 07-Dec-2008, 19:44

yeah that would work lol wasnt even thinking about that. Thanks for your help

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Array of Pointers to strings	clp	C++ Forum	6	28-Nov-2008 21:47
Accessing strings using pointers	anitha09	C Programming Language	5	17-Jan-2008 09:47
[Tutorial] Pointers in C (Part II)	Stack Overflow	C Programming Language	0	27-Apr-2005 18:36
[Tutorial] Pointers in C (Part I)	Stack Overflow	C Programming Language	1	08-Apr-2005 19:35

Problem assigning strings to pointers.

Re: Problem assigning strings to pointers.

Re: Problem assigning strings to pointers.