Traverse Function in a Linked List

mxb1145 · #1 07-Oct-2008, 21:56

Hey everyone,

I'm hoping one of you can help me figure out what's wrong with this code. I'm writing a traverse function that will print out the data for a linked list. For some reason I can't get it to print anything but the first thing in the list. I'm not sure what I'm doing wrong.

CPP / C++ / C Code:

template <class T>
	void List <T>::traverse(void(*visit)(T&))
	{
		Node<T> *temp1 = head;
		int number;
		while(temp1 != NULL)
		{
		       number = temp1->data;
		       temp1 = temp1->next;
		       (*visit)(number);
	              }
	}

ocicat · #2 07-Oct-2008, 22:34

Quote:

Originally Posted by mxb1145

CPP / C++ / C Code:

template <class T>
	void List <T>::traverse(void(*visit)(T&))
	{
		Node<T> *temp1 = head;
		int number;
		while(temp1 != NULL)
		{
		       number = temp1->data;
		       temp1 = temp1->next;
		       (*visit)(number);
	              }
	}

The general traversal code looks correct. If you are only able to process the first node, you need to determine whether the next field is indeed pointing to the next node in the linked list. I suspect it doesn't.

When posting code, place a [cpp] code tag before the code, & [/cpp] afterward to both preserve formating & color code keywords & identifiers.

Peter_APIIT · #3 08-Oct-2008, 04:18

Just need one line of code in while for traverse.

ocicat · #4 08-Oct-2008, 09:21

Quote:

Originally Posted by Peter_APIIT

Just need one line of code in while for traverse.

No, this is an incorrect assertion.

If minimalization was the issue, the while-loop could be reduced to:

CPP / C++ / C Code:

while(temp1 != NULL)
{
    (*visit)(temp1->data);
    temp1 = temp1->next;
}

...but optimization is pointless until correctness has been achieved.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
run script command on ns2.26	newbie06	Computer Software Forum - Linux	65	19-Aug-2009 08:50
Str_Misaligned in Double Link List	Peter_APIIT	C Programming Language	1	29-Feb-2008 21:50
Airport Log program using 3D linked List : problem reading from file	batrsau	C Programming Language	11	29-Feb-2008 08:44
Help in C Print is not working with LinkList	batman3280	C Programming Language	3	09-Mar-2006 20:03

Traverse Function in a Linked List

Re: Traverse Function in a Linked List

Re: Traverse Function in a Linked List

Re: Traverse Function in a Linked List