where is the problem and can you fix it (php)

oggie · #1 11-Apr-2008, 14:00

I am trying to get this all work together, and am not getting far. can anyone help me out. Cheers.

PHP Code:


<?php # header.html
// This page begins the HTML header for the site.
 
// start output buffering.
ob_start();
// Initialise a session.
session_start();
 
// Check for a $page_title value.
if (!isset($page_title)) {
$page_title = 'User Registration';
}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> 
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">         
<head>
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />
<title><?php echo $page_title; ?>
    </title>
<style type="text/css" media="screen"> @import url(./includes/layout.css);</style>
</head> 
 
<body>
<div id="Header">User Registration</div>
<div id="Content">
<!-- End of Header -->

SECOND SCRIPT. THIS CARRIES ON FROM THE ABOVE ONE. BUT I CANNOT SEE WHERE IT IS GOING WRONG.

PHP Code:


<! -- End of Content -->
</div>
</body>
</html>
<div id="Menu">
<a href="index.php">Home</a><br />
<?php # - footer.html
// This page completes the HTML template.
 
// Dispaly links based upon the login status.
// Show LOGIN links if this is the LOGOUT page.
if (isset($_SESSION['user_id']) AND (substr($_SERVER['PHP_SELF'], -10) !='logout.php')) {
echo '<a href="logout.php">logout</a><br />
<a href="change_password.php">Change password</a><br />';
} else { // not logged in.
echo '<a href="register.php">Register</a><br />
<a href="login.php">Login</a><br />
<a href="forgot_password.php">Forgot password</a><br />';
}
?>
<a href="#">Some page</a><br />
<a href="#">Another page</a><br />
</div>
<body>
</html>
<?php // Flush the buffered output.
ob_end_flush();
?>

THIRD SCRIPT. THIS SHOULD IN PRACTICE WORK BUT IT DOES NOT. sO NEED SOME HELP.

PHP Code:


<?php # index1.php
// This is he main page for the site.
 
// Include the config file for error management and such.
require_once ('./includes/config.inc.php');
 
// Set the page title and include the HTML header.
$page_title = 'User Registration';
include ('./includes/header.html');
 
// Welcomw the user (by name if they are loggied in).
echo '<h1>Welcome';
if (isset($_SESSION['first_name'])) {
echo ", {$_SESSION['first_name]}!";
}
echo </h1>;
?>
<p>Spam spam spam</p><br />
<p> Spam spam</p>
 
 
<?php // Include the HTML footer file.
include ('./includes/footer.html');
 
?>

as you can see I have put in quotes so you can see what is happening. Any help will be most grateful.

Thanks

Ian

TurboPT · #2 12-Apr-2008, 15:44

The "third script" is missing a single quote around first_name. (at the echo statement)

EDIT:
...and there should be quotes around the closing header with the echo after the if.

I don't have PHP on the machine I'm using at the moment, but if I get a chance later tonight, I'll try to run those.

oggie · #3 12-Apr-2008, 16:38

Hi,

Thanks for getting back. I have looked at the mistakes and rectified them. But I am still get a session problem on line 7 in the header.html. And also a problem in the footer.html.

And thanks for running these scripts if you get a chance. t is for a project I am doing for my work.

So any help will be of grate value.

Kind regards

Ian

TurboPT · #4 12-Apr-2008, 20:12

I'm not sure what problem you're seeing (unless I'm missing something?), but here's the output (from html) that I get:

Code:

User Registration

Welcome

Spam spam spam

Spam spam

Home
Register
Login
Forgot password
Some page
Another page

(of course the last several items are links)

EDIT:
...a couple of minor notes
1. there are two </html> tags in the footer file. Is this intentional? I only see one opening tag in the header.
2. the footer file also has a stray <body> tag near the end.

oggie · #5 13-Apr-2008, 07:24

TurboPT · #6 13-Apr-2008, 10:40

For the session_start problem, see this post for a possible solution.

oggie · #7 14-Apr-2008, 08:28

Thanks for that. It seems to of worked as all those error messages have gone but now I am getting this message:

Warning: require_once(/includes/config.inc.php) [function.require-once]: failed to open stream: No such file or directory in /home/ogl10b7/public_html/EricsCarRepairs/register.php on line 5

Fatal error: require_once() [function.require]: Failed opening required '/includes/config.inc.php' (include_path='.:/usr/share/php:/usr/share/pear') in /home/ogl10b7/public_html/EricsCarRepairs/register.php on line 5

this is the path to this message:

http://loki.computing.boston.ac.uk/~ogl10b7/EricsCarRepairs/register.php

Ian

TurboPT · #8 14-Apr-2008, 12:13

Maybe the path needs the leading . (period)? [it doesn't appear in the message, at least]

PHP Code:


require_once('./includes/config.inc.php');

instead of:

PHP Code:


require_once('/includes/config.inc.php');

oggie · #9 14-Apr-2008, 15:08

I have put the . in and it now comes up with:

Warning: require_once(/.includes/config.inc.php) [function.require-once]: failed to open stream: No such file or directory in /home/ogl10b7/public_html/EricsCarRepairs/register.php on line 5

Fatal error: require_once() [function.require]: Failed opening required '/.includes/config.inc.php' (include_path='.:/usr/share/php:/usr/share/pear') in /home/ogl10b7/public_html/EricsCarRepairs/register.php on line 5

<?php # register.php
// This is the registration page for the site.

// Include the config file for error management and such.
require_once ('/.includes/config.inc.php');

// Set the page title and include the HTML header.
$page_title = 'Register';
include ('/.includes/header.html');

if (isset($_POST['submitted'])) { // Handle the form.

require_once ('../mysql_connect.php'); // Connect to the database.

// Check for a fisrt name.
if (ergi ('^[[:alpha:]\.\'\-]{2,15}$', stripslashes(trim($_POST['first_name'])))) {
$fn = escape_data($_POST['first_name']);
} else {
$fn = FALSE;
echo '<p><font color="red" size="+1">Please enter your first name!</font></p>';
}

// Check for a last name.
if (ergi ('^[[:alpaha:}\.\'\-]{2,30}$', stripslashes(trim($_POST['last_name'])))) {
$ln = escape_data($_POST['last_name']);
} else {
$ln = FALSE;
echo '<p><font color="red" size="+1">Please enter your last name!</font></p>';
}

// Check for an email address.
if (ergi('^[[:alnum:]][a-z0-9_\.\-]*@[a-z0-9\.\-]+\.[a-z]{2,4}$', stripslashes(trim($POST['email'])))) {
$e = escape_data($_POST['email']);
} else {
$e = FALSE;
echo '<p><font color="red" size="+1">Please enter a valid email address!</font></p>';
}

// Check for a password and math against the conforme password.
if (ergi('^[[:alnum:]]{4,20}$', stripslashes(trim($_POST['password1'])))) {
if ($_POST['password1'] == $_POST['password2']) {
$p = escape_data($_POST['password1']);
} else {
$p = FALSE;
echo '<p><font color="red" size="+1">Your password did not match the confirmed password!</font></p>';
}
} else {
$p = FALSE;
echo '<p><font color="red" size="+1">Please enter a valid password!</font></p>';
}

if ($fn && $ln && $e && $p) { // If everything's OK.

// Make sure the email address is available.
$query = "SELECT user_id FROM register WHERE email='$e'";
$result = mysql_query ($query) or trigger_error("Query: $query\n<br />MySQL ERROR: " . mysql_error());

if (mysql_num_rows($result) == 0) { // Available.

// Create the activation code.
$a = md5(uniqid(rand(), true));

// Add the user.
$query = "INSERT INTO register (email, pass, first_name, last_name, active, registration_date) VALUES ('$e', SHA('$p'), '$fn', '$ln', '$a', NOW()";
$result = mysql_query ($query) or trigger_error("QUERY: $query\n<br />MySQL ERROR:" . mysql_error());

if (mysql_affected_rows() == 1) { // If it ran OK.

// Send the email.
$body = "Thankyou for registering. To activate your account, please click on this link:\n\n";
$body .="http://www.whateveraddressyouwantthere.com/activate.php?x=" . mysql_insert_id() . "&y=$a";
mail($_POST['email'],'Registration confirmation',$body);

// Finish the page.
echo '<h3>Thankyou for registering! A confirmation email has been sent to your address. Please click on the link in that the email in order to activate your account.</h3>';
include ('.includes/footer.html'); // Include the HTML footer.
exit();

} else { // If it did not run OK.
echo '<p><font color="red" size="+1">You could not be registerd due to a system error. We apologize for any inconvenience.</font></p>';
}

} else { // The email address is not available.
echo '<p><font color="red" size="+1"> That email has already been registered. If you have forgotten your password, use the link to have your password sent to you.</font></p>';
}

} else { // If one of the data testa failed.
echo '<p><font color="red" size="+1">Please try again.</font></p>';
}

mysql_close(); // Close the database connection.

} // End of the main submit conditional.
?>

<h1>Register</h1>
<form action="register.php" method="post">
<fieldset>

<p><b>First Name:</b> <input type="text" name="first_name" size="15" maxlength="15" value="<?php if (isset($_POST['first_name'])) echo $_POST['first_name']; ?>" /> </p>

<p><b>Last Name:</b> <input type="text" name="last_name" size="30" maxlength="30" value="<?php if (isset($_POST['last_name'])) echo $_POST['last_name']; ?>" /> </p>

<p><b>Email:</b> <input type="text" name="email" size="40" maxlength="40" value="<?php if (isset($_POST['email'])) echo $_POST['email']; ?>" /> </p>

<p><b>Password:</b> <input type="password" name="password1" size="20" maxlength="20" /><small>Use only letters and numbers. Must be between 4 and 20 characters long</small></p>

<p><b>Confirm Password:</b> <input type="password" name="password2" size="20" maxlength="20" /></p>
</fieldset>

<div align="center"><input type="submit" name="submit" value="Register" /></div>
<input type="hidden" name="submitted" value="TRUE" />

</form>

<?php // Include the HTML footer.
include ('/.includes/footer.html')
?>

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)

Re: where is the problem and can you fix it (php)