#include <stdio.h>
#include <stdlib.h>
#define numberOfValues 5     /* this will become an argument passed to this function */

void decbin(int decimal, char *binary); /* Function Prototype */
void bindec(char binary[], int *decimal); /* Function Prototype */

void main(void)  // return type will be changed later

/* 'sort' is the primary method which is initially called. The input values and the number of
values to be sorted are passed here. As the memory required by the array is unknown, I have 
ensured through the use of my 'malloc' subroutine that 32 bytes of memory multiplied by the 
number of values passed to the 'sort' method are allocated. Initially,  sort then calls 'decbin' 
to convert the values in to binary form. Finally, 'bindec' is called, which will
reconvert the sorted numbers in to decimal form, so that they can be passed back correctly. */

// PROBLEM SEEMS TO LIE IN NOT PASSING DECIMAL VALUE CORRECTLY & THEN PRINTING IN TEST FUNCTION.

	{

		int inputValues[numberOfValues] = {20, 10, 400, 2089, 1};   /* will be replaced by ptr to input array eventually */
		int curValue;
		char *binary;

		binary = malloc(numberOfValues * 32);

		for (curValue = 0; curValue < numberOfValues; curValue++)
			decbin(inputValues[curValue], &(binary[curValue]));

		for (curValue = 0; curValue < numberOfValues; curValue++)
			bindec(&(binary[curValue]), &(inputValues[curValue]));

        return;

	}

void decbin(int decimal, char *binary)

/* This function converts a decimal value to binary by continuously updating the string 
of remainders, until eventually it is fully converted. This is achieved through the use 
of a do...while loop. The values are then entered in to an array and treated as a string. 
Because of this, it is easy to reverse the order of the values and construct the correct 
binary value of the number. */

	{

		int curBit = 31;
		int remainder;
		int i = 0; // for testing

		printf("The binary value of %d is ", decimal);

			do
			{
				remainder = decimal % 2;
				decimal = decimal / 2;
				binary[curBit] = remainder;
				curBit--;
			}
			while (decimal > 0);
			
		for ( ; curBit >= 0; curBit--)
			binary[curBit] = 0;

		while (binary[i] == 0)
			i++;
		
		for ( ; i < 32; i++)
			printf ("%d", binary[i]);
		
		printf ("\n");
		
        return;
        
	}

void bindec(char binary[], int *decimal)

	{
	
		int power(int counter); /* Function Prototype */
	
		int counter = 0;
		int curValue = 0;

		*decimal = 0;
		for (counter = 31; counter >= 0; counter--)
			{
				if (binary[counter] == 1)
					*decimal += power(counter);
			}
			
		for (curValue = 0; curValue < numberOfValues; curValue++)
			{
				int i;
				printf("The decimal value of %d is, ", binary[curValue]);

		for (i = 0; binary[curValue * 32 + i] == 0; i++);
		
				for ( ; i < 32; i++)
					printf ("%d", *decimal);
				printf ("\n");
			}

		return;

	}

int power(int counter)
	
/* This function is utilised to determine the total amount that is to be added to the 
previous decimal value. If the counter value passed to this function is already 0, then 
the value returned will default to 1. */

	{

		int twoPowered = 1;

		for( ; counter < 31; counter++)

			{
				twoPowered *= 2;
			}

		return twoPowered;

	}

    for (curValue = 0; curValue < numberOfValues; curValue++) {
        decbin(inputValues[curValue], &(binary[curValue*32]));
    }

    for (i = 0; i < numberOfValues; i++) {
        printf("inputValues[%d] = %d\n", i, inputValues[i]);
        printf("binary[%3d]: ", i * 32);
        for(curValue = i*32; curValue < (i+1)*32; curValue++) {
            printf("%d ", binary[curValue]);
        }
        printf("\n\n");
    }
    printf("\n");

    for (curValue = 0; curValue < numberOfValues; curValue++) {
        bindec(&(binary[curValue*32]), &(inputValues[curValue]));
        printf("inputValues[%d] = %d\n", curValue, inputValues[curValue]);
    }

#include <stdio.h>
#include <stdlib.h>
#include <pthread.h>
#define numberOfValues 5     /* this will become an argument passed to this function */

void decbin(int decimal, int cellArray[][32], int curValue); /* Function Prototype */

void main(void)  // Will become ptr to input array and number of values

	{

		int inputValues[numberOfValues] = {20, 10, 400, 2089, 1};   /* will be replaced by ptr to input array */
		int curValue;
		int cellArray[numberOfValues][32];

//		cellArray = malloc(numberOfValues * 32);    malloc doesn't work on multidimensional arrays? maybe need an alternative.

		for (curValue = 0; curValue < numberOfValues; curValue++)
			decbin(inputValues[curValue], &(cellArray[curValue][32]), curValue);

         }

void decbin(int decimal, int cellArray[][32], int curValue)

/* This function converts a decimal value to binary by continuously updating the string 
of remainders, until eventually it is fully converted. This is achieved through the use 
of a do...while loop. */

	{

		int binBit = 31;
		int remainder;
		int i = 0; // for testing

		printf("The binary value of %d is ", decimal);

			do
			{
				remainder = decimal % 2;
				decimal = decimal / 2;
				cellArray[curValue][binBit] = remainder;
				binBit--;
			}
			while (decimal > 0);
			
		for (binBit; binBit >= 0; binBit--)
			cellArray[curValue][binBit] = 0;

		while (cellArray[curValue][i] == 0)
			i++;
		
		for ( ; i < 32; i++)
			printf ("%d", cellArray[curValue][i]);
		
		printf ("\n");
		
        return;
        
	}

    decbin(inputValues[curValue], &(cellArray[curValue][32]), curValue);

void decbin(int decimal, int cellArray[][32], int curValue)

		for (curValue = 0; curValue < numberOfValues; curValue++)
			decbin(inputValues[curValue], cellArray, curValue);

 #include <pthread.h>