Storing strings in an array...

MSUracer · #1 14-Oct-2006, 16:29

got another one for you guys...

i need to take up to 15 names from the user, and store them in an array. here's what i have so far...

CPP / C++ / C Code:

#include <iostream>
#include <string>
#include <cstring>
using namespace std;

int main()
{
    string name;
    int numnames = 0;
    int max = 14;
    string totnames[max];
    
    cout << "Enter a name.  Enter 'finished' to stop." << endl;
    cin >> name;
    while ((name != "finished") && (numnames < max))
    {
          cout << "Enter another name. Enter 'finished' to stop."<< endl; 
          name = totnames[numnames];  
          numnames++;
          cin >> name;        
    }
    
    
    cout << "You have entered the following names:" << endl;
    cout << name << endl;
    
    system("pause");


}

it will accept up to 15 names, and will stop accepting names when "finished" is entered, but it will only print out "finished" or the last name i entered. im pretty sure it's a small mistake, but i can't find it.

thanks in advance.
ryan

ubergeek · #2 14-Oct-2006, 16:30

It looks like the code you have to save the name is

CPP / C++ / C Code:

name = totnames[numnames];

This is backwards. You want

CPP / C++ / C Code:

totnames[numnames] = name;

By the way, some compilers (those that adhere most strictly to the standard) won't let you (or at least will issue a warning telling you not to) declare an array with variable dimensions. By that I mean the number 14 has to be a #define'd constant.

MSUracer · #3 14-Oct-2006, 16:39

thanks, ill give that a shot. kudos to a quick response, too.

MSUracer · #4 14-Oct-2006, 16:45

hmm, i switched them around, same result. i played around with my cout statement some...

if i use

CPP / C++ / C Code:

cout << "You have entered the following names:" << endl;
    cout << name << endl;

then i get "finished" or the last name entered.

if i use

CPP / C++ / C Code:

cout << "You have entered the following names:" << endl;
    cout << totnames[numnames] << endl;

then i get black space displayed.

what do i want to use in that cout statement?

if i use

CPP / C++ / C Code:

cout << "You have entered the following names:" << endl;
    cout << numnames << endl;

then i get the number of names i entered. i think my loop works, im just asking for the wrong information from it?

ubergeek · #5 14-Oct-2006, 17:08

It's hard to guess what you've done without seeing all of the new code. The key is to make sure you store the newly inputted string in an array before overwriting the variable.

MSUracer · #6 14-Oct-2006, 17:32

CPP / C++ / C Code:

#include <iostream>
#include <string>
#include <cstring>
using namespace std;

int main()
{
    string name;
    int numnames = 0;
    int max = 14;
    string totnames[max];
    
    cout << "Enter a name.  Enter 'finished' to stop." << endl;
    cin >> name;
    while ((name != "finished") && (numnames < max))
    {
          cout << "Enter another name. Enter 'finished' to stop."<< endl; 
          totnames[numnames] = name;  
          numnames++;
          cin >> name;        
    }
    
    int a;
    cout << "You have entered the following names:" << endl;
    for (a = 0; a < numnames; a++)
        cout << name << endl;
    
    system("pause");


}

i'm a little closer with this one. i forgot that i need a loop to print out all the names stored. added the loop, and the program now prints out the correct number of names, but it prints out either "finished" or the last name entered for each entry.

ex:
if the user inputs "red, green, blue," then "finished," i get "finished, finished, finished," for my output.
any ideas?

Sokar · #7 14-Oct-2006, 18:42

What you posted will not compile for me. I get the following errors.

error C2057: expected constant expression (int max = 14;)
error C2466: cannot allocate an array of constant size 0 (string totnames[max];)
error C2133: 'totnames' : unknown size (string totnames[max];)
error C2059: syntax error : '<<' (cout << << endl;)

But with fixing those errors I get this output.

Enter a name. Enter 'finished' to stop.
red, green, blue," then finished
Enter another name. Enter 'finished' to stop.
Enter another name. Enter 'finished' to stop.
Enter another name. Enter 'finished' to stop.
Enter another name. Enter 'finished' to stop.
You have entered the following names:
red,
green,
blue,"
then

MSUracer · #8 14-Oct-2006, 18:56

fixed it, sorry. i forgot to put the "name" back in the cout statement, hence the two <<'s. i appreciate the help, but i dont know what those errors mean. care to explain?

Sokar · #9 14-Oct-2006, 19:07

Quote:

Originally Posted by MSUracer

i appreciate the help, but i dont know what those errors mean. care to explain?

Sure. I will not debate this with other members. But "max" should be a constant.
http://msdn.microsoft.com/library/de...html/C2057.asp

Where did you store the names(in what variable)?

MSUracer · #10 14-Oct-2006, 19:12

im attempting to store the names entered into the variable "name," and then put the different "name"s into an array, that i can search (that comes later).

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
How to clear the strings in the array?	jpxtreme	C Programming Language	9	29-Sep-2006 07:41
Need help deleting the last element in the array	headphone69	C++ Forum	2	15-Mar-2006 20:31
Declaring an array of strings dynamically (C Language)	Hyuga	C Programming Language	5	03-Aug-2005 10:18
template comiling problems - need expert debugger!	crq	C++ Forum	1	01-Feb-2005 22:26
array of pointers to strings	mirizar	C++ Forum	5	21-Jan-2005 11:24

Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...

Re: Storing strings in an array...